Skip to content

Rename post scripts#1037

Closed
WalterKolczynski-NOAA wants to merge 1 commit into
NOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/rename_post
Closed

Rename post scripts#1037
WalterKolczynski-NOAA wants to merge 1 commit into
NOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/rename_post

Conversation

@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Sep 29, 2022

Description
Rename post scripts to remove the unnecessary "ncep" qualifier. Also changes the executable name for upp to be the one produced by upp (upp.x).

The ush/global_nceppost.sh script is removed as it is not used by any job. We may want to rename the gfs_post.sh script (the one that is used) to global_post.sh to be more reflective of its usage.

Type of change

  • Maintenance (alteration that does not change functionality)

How Has This Been Tested?

  • Forecast-only test on Hera
  • Cycled test on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the maintenance Regular updates and maintenance work label Sep 29, 2022
@WalterKolczynski-NOAA WalterKolczynski-NOAA self-assigned this Sep 29, 2022
@WalterKolczynski-NOAA
Rename post scripts
3fee66f 
Rename post scripts to remove the unnecessary "ncep" qualifier.
github-advanced-security[bot]
github-advanced-security AI found potential problems Sep 29, 2022
View reviewed changes
Comment thread jobs/JGLOBAL_ATMOS_POST Outdated

Check warning

Code scanning / shellcheck

SCRgfs is referenced but not assigned.

SCRgfs is referenced but not assigned.
Comment thread jobs/JGLOBAL_ATMOS_POST Outdated

Check warning

Code scanning / shellcheck

Double quote to prevent globbing and word splitting.

Double quote to prevent globbing and word splitting.
Comment thread jobs/JGLOBAL_ATMOS_POST Outdated

Check warning

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required.

Prefer putting braces around variable references even when not strictly required.
Comment thread jobs/JGLOBAL_ATMOS_POST Outdated

Check warning

Code scanning / shellcheck

Double quote to prevent globbing and word splitting.

Double quote to prevent globbing and word splitting.
Comment thread scripts/exgdas_atmos_post.sh Outdated

Check warning

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required.

Prefer putting braces around variable references even when not strictly required.
@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor Author

WalterKolczynski-NOAA commented Sep 29, 2022

Kate is already making most of these linter fixes in PR #1030, so I'm going to close this PR and hold until that is merged.

JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/global-workflow that referenced this pull request Nov 7, 2025
@ukmo-ccbunney
Bugfix - initialised VD and VS to zero in w3srcemd. (NOAA-EMC#1037)
17a4e32
bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026
@grantfirl
Add lsm_cold_start variable for RUC LSM SCM support and gwdps bugfix …
4a42680 
…(combined) (NOAA-EMC#1037)

Co-authored-by: @SMoorthi-emc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul Awaiting requested review from aerorahul

@KateFriedman-NOAA KateFriedman-NOAA Awaiting requested review from KateFriedman-NOAA

Assignees

@WalterKolczynski-NOAA WalterKolczynski-NOAA

Labels

maintenance Regular updates and maintenance work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WalterKolczynski-NOAA @github-advanced-security